Fix POSIX shell compatibility in send-phonehome script#1517
Merged
gsanchietti merged 2 commits intomy_migrationfrom Feb 11, 2026
Merged
Fix POSIX shell compatibility in send-phonehome script#1517gsanchietti merged 2 commits intomy_migrationfrom
gsanchietti merged 2 commits intomy_migrationfrom
Conversation
Co-authored-by: gsanchietti <804596+gsanchietti@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from PR #1509 for enterprise portal proxy feature
Fix POSIX shell compatibility in send-phonehome script
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
send-phonehomescript uses#!/bin/shbut had a non-POSIX string comparison operator.Changes
==to=in string comparison on line 28 for POSIX complianceThe
=operator is portable across all POSIX shells, while==is a bash-specific extension.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.